New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable case insensitive on segment search #18643
Conversation
@diosmosis did a simple update for segment insensitive search. Hopefully, I did it right. |
plugins/CorePluginsAdmin/vue/src/FormField/FieldExpandableSelect.vue
Outdated
Show resolved
Hide resolved
btw @peterhashair As the issue is meant to be included in the 4.7.0 final, your pull request should have been based on and targeted to the |
enable case insentive
shorter the function
d35efd8
to
70dd0ed
Compare
use toLowerCase
@peterhashair This looks good for me now. |
add test for auto complete
Maybe would be better to have a UI test that performs a search with a capital letter in it and then checks the results are the same? |
update tests
update selector
update selector
update click
update tests
update screenshot
update tests
add click before typo
This reverts commit d577719.
update tests
update tests
update tests selector
update tests
update tests
update screenshot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peterhashair the capitalized
screenshot needs to be updated. It's currently an empty file.
Once tests are passing, that is good to merge.
update screen shot
I guess that should be good to go |
Description:
Fixes: #18640
enable case insensitive on segment search
Review