@peterhashair opened this Pull Request on January 18th 2022 Contributor

Description:

Fixes: #18640
enable case insensitive on segment search

Review

@peterhashair commented on January 18th 2022 Contributor

@diosmosis did a simple update for segment insensitive search. Hopefully, I did it right.

@sgiehl commented on January 18th 2022 Member

btw @peterhashair As the issue is meant to be included in the 4.7.0 final, your pull request should have been based on and targeted to the next_release branch. I will rebase your branch and change the PR base. You may need to do a hard reset to the origin before doing any further changes though

@sgiehl commented on January 18th 2022 Member

@peterhashair This looks good for me now.
For regressions its always good to check if we can adjust our tests so this will be covered for the future. Not sure if we already have a UI test that uses such a field for searching, but guess that could be added to the SegmentSelectorEditor tests maybe.

@justinvelluppillai commented on January 18th 2022 Member

Maybe would be better to have a UI test that performs a search with a capital letter in it and then checks the results are the same?

@peterhashair commented on January 19th 2022 Contributor

I guess that should be good to go

This Pull Request was closed on January 20th 2022
Powered by GitHub Issue Mirror