enable case insensitive on segment search
@diosmosis did a simple update for segment insensitive search. Hopefully, I did it right.
btw @peterhashair As the issue is meant to be included in the 4.7.0 final, your pull request should have been based on and targeted to the
next_release branch. I will rebase your branch and change the PR base. You may need to do a hard reset to the origin before doing any further changes though
@peterhashair This looks good for me now.
For regressions its always good to check if we can adjust our tests so this will be covered for the future. Not sure if we already have a UI test that uses such a field for searching, but guess that could be added to the SegmentSelectorEditor tests maybe.
Maybe would be better to have a UI test that performs a search with a capital letter in it and then checks the results are the same?
I guess that should be good to go