@peterhashair
Description:
Fixes: #18637
after setting save success, should scroll to notification
Review
- [ ] Functional review done
- [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- [ ] Security review done
- [ ] Wording review done
- [ ] Code review done
- [ ] Tests were added if useful/possible
- [ ] Reviewed for breaking changes
- [ ] Developer changelog updated if needed
- [ ] Documentation added if needed
- [ ] Existing documentation updated if needed
@diosmosis sorry to bother got a question. when I run ./console vue:build it returns random errors on 4.x-dev.
Also here, should that be a catch method instead of finally? https://github.com/matomo-org/matomo/blob/165be4f4ea40cbca50ae71821e517e6edb6054ba/plugins/CoreAdminHome/vue/src/ArchivingSettings/ArchivingSettings.vue#L178
@diosmosis
when I run ./console vue:build it returns random errors on 4.x-dev.
I've noticed this, seems to be a tsc issue/bug, but I don't know how to fix it. Currently just rebuilding when it happens. It doesn't happen very often for me (once a day at most).
Also here, should that be a catch method instead of finally?
It should be finally, unless you want to show the loading gif if there's an error. (EDIT: "no error" not an error.)
@diosmosis I saw someone solved it by add this https://www.npmjs.com/package/eslint-import-resolver-typescript
Thanks, @peterhashair! Do you have info on how they used it, specifically w/ vue CLI?
@diosmosis haven't try myself, but they claim work like this https://github.com/nklayman/vue-cli-plugin-electron-builder/issues/1059