@peterhashair opened this Pull Request on January 17th 2022 Contributor

Description:

Fixes: #18637
after setting save success, should scroll to notification

Review

@peterhashair commented on January 18th 2022 Contributor

@diosmosis sorry to bother got a question. when I run ./console vue:build it returns random errors on 4.x-dev.
image

Also here, should that be a catch method instead of finally? https://github.com/matomo-org/matomo/blob/165be4f4ea40cbca50ae71821e517e6edb6054ba/plugins/CoreAdminHome/vue/src/ArchivingSettings/ArchivingSettings.vue#L178

@diosmosis commented on January 18th 2022 Member

when I run ./console vue:build it returns random errors on 4.x-dev.

I've noticed this, seems to be a tsc issue/bug, but I don't know how to fix it. Currently just rebuilding when it happens. It doesn't happen very often for me (once a day at most).

Also here, should that be a catch method instead of finally?

It should be finally, unless you want to show the loading gif if there's an error. (EDIT: "no error" not an error.)

@peterhashair commented on January 19th 2022 Contributor
@diosmosis commented on January 19th 2022 Member

Thanks, @peterhashair! Do you have info on how they used it, specifically w/ vue CLI?

@peterhashair commented on January 19th 2022 Contributor
This Pull Request was closed on January 18th 2022
Powered by GitHub Issue Mirror