Enrich log_visit table index by a third column #18636
Conversation
There was a problem hiding this comment.
@JasonMortonNZ This looks good now and should be good to merge
Just one last thing that needs to be clarified. How much of a need is the descending order? That is actually only supported by MySQL 8. Older MySQL versions will simply ignore the DESC
@tsteur If we are starting to use some MySQL 8 features, we maybe should recommend using MySQL 8 in our docs, even though we are still supporting older versions.
|
@sgiehl changed that guide to recommend MySQL 8.
It's not needed. On Cloud we don't run it on MySQL 8 either but it still helped. |
|
@tsteur if that's the case, why do we know that a |
|
The find visitor query does a DESC and so the most others if I remember correctly. I don't think it's needed for the others but we could always test later down the road. We haven't seen any issues there so far. |
|
@tsteur feel free to put this into a milestone it should be included or even merge it right away |
sgiehl
changed the title
Description:
Issue: dev-2431
This PR improves the existing log_visit table index by including a third column within the index. The schema change will allow all new installations to benefit from the improved index, while the update script is earmarked for the 5.0.0 release.
Review