Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] add fromEntries polyfill and fix spread operator compiling #18630

Merged
merged 4 commits into from Jan 17, 2022
Merged

[Vue] add fromEntries polyfill and fix spread operator compiling #18630

merged 4 commits into from Jan 17, 2022

Conversation

diosmosis
Copy link
Member

Description:

Changes:

  • add fromEntries polyfill for older browsers
  • make sure to use Object.assign for object spread operator since the functions inserted by babel do not work on all older browsers

Review

@diosmosis diosmosis added Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review labels Jan 16, 2022
@diosmosis diosmosis added this to the 4.7.0 milestone Jan 16, 2022
@justinvelluppillai justinvelluppillai changed the base branch from 4.x-dev to next_release January 17, 2022 03:18
@justinvelluppillai
Copy link
Contributor

Have changed the merge base to next_release so this can be included in 4.7.0 once reviewed.

@sgiehl
Copy link
Member

sgiehl commented Jan 17, 2022

@justinvelluppillai just FYI:
I will merge this one now, but will directly merge next_release to 4.x-dev locally and push the update to 4.x-dev, so we don't get duplicate commits and too many merge conflicts later

@sgiehl sgiehl merged commit 874ebd3 into next_release Jan 17, 2022
@sgiehl sgiehl deleted the vue-from-entries-polyfill branch January 17, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @justinvelluppillai @sgiehl