@bx80 opened this Pull Request on January 15th 2022 Contributor


As part of the recent Visual indication of incomplete periods on charts change (#18086), a check is performed on the currently selected period and date to determine if the period contains the current date. (eg. Period = 'week', Date = '2022-01-20'). This check is called by jqplot.js and executed by the periods service.

The A/B testing plugin for some internal reason needs to set the period to 'day' but the date to a range (eg. '2021-01-20,2021-01-27). This causes the containsToday check to fail as a valid date cannot be parsed from a date range.

This PR adds a simple check before calling attempting to parse the date period, if the date is a range then the period type will be forced to type 'range' for the purposes of the containsToday check only.

Ref L3-205


This Pull Request was closed on January 17th 2022
Powered by GitHub Issue Mirror