[Vue] rename PluginSetting component to GroupedSetting component and refactor condition handling
#18628
Needs Review4.8.0
@diosmosis
opened this Pull Request on January 15th 2022
Member
Description:
Changes:
rename PluginSetting component to GroupedSetting (changed :plugin-name to :group-name and allow it to be optional)
This component encapsulates the Vue side handling of the formField.condition parameter in angularjs, but in a way that doesn't require FormField to know about every other setting/setting value. It's used in measurable settings and tag manager parameters.
refactored condition handling to take place in GroupedSetting instead of FormField to reduce the amount of work FormField does and so we don't have to pass a dynamic function as a property to FormField and so FormField doesn't have to show/hide itself. BC w/ angularjs should still be maintained.
@sgiehl@peterhashair it would be good to review this one before doing the sitesmanager PRs.
[ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
[ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)