Description:

piwikHelper.modalConfirm() uses every button w/ [role] even if it belongs to a nested modal. This doesn't appear to be an issue w/ angularjs code due to the timing in when angularjs processes templates/materialize creates modal content. With vue, the HTML appears to show up quicker.

To reproduce, check out matomo-org/tag-manager#404 and try to import a version. In the modal, you'll see "Yes"/"No" buttons which actually belong to the #confirmImportContainerVersion modal stored in the import version directive.

Fixed by checking for the number of .ui-confirm parents contained in the modal contents and skipping the button if it's more than 1.

Review

• Functional review done
• Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• Security review done
• Wording review done
• Code review done
• Tests were added if useful/possible
• Reviewed for breaking changes
• Developer changelog updated if needed
• Documentation added if needed
• Existing documentation updated if needed