@diosmosis opened this Pull Request on January 14th 2022 Member

Description:

piwikHelper.modalConfirm() uses every button w/ [role] even if it belongs to a nested modal. This doesn't appear to be an issue w/ angularjs code due to the timing in when angularjs processes templates/materialize creates modal content. With vue, the HTML appears to show up quicker.

To reproduce, check out https://github.com/matomo-org/tag-manager/pull/404 and try to import a version. In the modal, you'll see "Yes"/"No" buttons which actually belong to the #confirmImportContainerVersion modal stored in the import version directive.

Fixed by checking for the number of .ui-confirm parents contained in the modal contents and skipping the button if it's more than 1.

Review

This Pull Request was closed on January 14th 2022
Powered by GitHub Issue Mirror