Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor emails about password reset into a Mail sub-class #18616

Merged
merged 1 commit into from Jan 14, 2022

Conversation

samjf
Copy link
Contributor

@samjf samjf commented Jan 13, 2022

Description:

Ref: DEV-2501

Summary: Refactor emails about password reset into a Mail sub-class.

This refactors the emails produced by the PasswordResetter into their own sub-class of Mail. Before this it simply composed emails from the generic Mail class.

This will allow subscribers of the Mail.shouldSend hook to better differentiate between what emails are being sent.

Review

@samjf samjf added the Needs Review PRs that need a code review label Jan 13, 2022
Copy link
Contributor

@justinvelluppillai justinvelluppillai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and works here.

@justinvelluppillai justinvelluppillai merged commit 8e1aabf into 4.x-dev Jan 14, 2022
@justinvelluppillai justinvelluppillai deleted the D2501-refactor-password-reset-email branch January 14, 2022 01:05
@justinvelluppillai
Copy link
Contributor

(The failing tests seem unrelated)

@justinvelluppillai justinvelluppillai added this to the 4.7.0 milestone Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants