Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] use markRaw with FieldAngularJsTemplate to get rid of vue warning #18613

Merged
merged 3 commits into from Jan 13, 2022
Merged

[Vue] use markRaw with FieldAngularJsTemplate to get rid of vue warning #18613

merged 3 commits into from Jan 13, 2022

Conversation

diosmosis
Copy link
Member

Description:

To test: check uses of templateFile in piwik-form-field (eg, RollUpReporting edit site, a couple places in TagManager)

Review

@diosmosis diosmosis added the Needs Review PRs that need a code review label Jan 13, 2022
@diosmosis diosmosis added this to the 4.7.0 milestone Jan 13, 2022
peterhashair
peterhashair approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@peterhashair peterhashair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@diosmosis diosmosis merged commit 4ba705e into 4.x-dev Jan 13, 2022
@diosmosis diosmosis deleted the vue-form-field-mark-raw branch January 13, 2022 06:47
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhashair peterhashair peterhashair approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @peterhashair @justinvelluppillai