Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide commands that don't work on windows #18604

Merged
merged 1 commit into from Jan 11, 2022
Merged

Hide commands that don't work on windows #18604

merged 1 commit into from Jan 11, 2022

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jan 11, 2022

Description:

This simply hides the commands that won't work on windows. Alternatively we could also check if there would be any commands that need to be run instead.

fixes #18603

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jan 11, 2022
@justinvelluppillai justinvelluppillai merged commit 170c87c into 4.x-dev Jan 11, 2022
@justinvelluppillai justinvelluppillai deleted the windowsfix branch January 11, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinvelluppillai justinvelluppillai justinvelluppillai approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide commands that don't work on windows
2 participants
@sgiehl @justinvelluppillai