Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for datatable row sum warning message #18600

Merged
merged 1 commit into from Jan 11, 2022
Merged

Conversation

bx80
Copy link
Contributor

@bx80 bx80 commented Jan 11, 2022

Description:

Fixes #18468

This is a follow up to the earlier #18500 fix to ensure that when summing up datatable row array columns that each of the array keys is checked against the unsummable columns list and is not summed if present there. This should prevent attempts to sum up the ts_archived string date value in the row _metadata array column and subsequent warning messages.

Review

@bx80 bx80 added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jan 11, 2022
@bx80 bx80 added this to the 4.7.0 milestone Jan 11, 2022
@bx80 bx80 self-assigned this Jan 11, 2022
@bx80 bx80 added the Needs Review PRs that need a code review label Jan 11, 2022
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgiehl sgiehl removed the Needs Review PRs that need a code review label Jan 11, 2022
@sgiehl sgiehl merged commit ec3e220 into 4.x-dev Jan 11, 2022
@sgiehl sgiehl deleted the m-18468-row-metadata-sum-fix branch January 11, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WARNING: /core/DataTable/Row.php(805) after update to 4.6.1
2 participants