@peterhashair opened this Pull Request on January 10th 2022 Contributor

Description:

Fixes: #18448
add disable finger print

FAQ Preview: https://matomo.org/faq/how-do-i-disable-browser-feature-detection-completely/

Review

@peterhashair commented on January 10th 2022 Contributor

@tsteur sorry to bother, just checking if I am on the right track.

@justinvelluppillai commented on January 12th 2022 Contributor

@peterhashair why are you adding those eslint rules?

@peterhashair commented on January 12th 2022 Contributor

@justinvelluppillai
Ah maybe we need those ignore it throw lots of errors for pikwi.js, see screen shots
image

@peterhashair commented on January 12th 2022 Contributor

build js

@justinvelluppillai commented on January 14th 2022 Contributor

@peterhashair be good to get this one ready for next review and request reviewer if it is being ignored. Also looking at the FAQ I think maybe it is better to add the information to this page which describes how the config_id works more generally also https://matomo.org/faq/general/how-is-the-visitor-config_id-processed/ (or at least link to this page and the page on fingerprinting).

@peterhashair commented on January 15th 2022 Contributor

@justinvelluppillai sure, will do.

@peterhashair commented on January 17th 2022 Contributor

build js

@tsteur commented on January 17th 2022 Member

@justinvelluppillai I haven't fully tested it but I think we could merge for now so it's in the release. Then add some follow up work like add also an enable... method (which they can call if they get consent) and maybe there could be also one or more automated tests for this? Like making sure when the feature is disabled, that we're not sending any browser resolution in the tracking request?

@justinvelluppillai commented on January 17th 2022 Contributor

This is looking good thanks @peterhashair, still good to publish your FAQ and update the other mentioned doc, after that once these tests pass this is good to merge and will probably be the last merge before the next RC.

@peterhashair commented on January 17th 2022 Contributor

@justinvelluppillai updated the FAQ, just reference a link at the bottom. publish it now.

@peterhashair commented on January 17th 2022 Contributor
This Pull Request was closed on January 17th 2022
Powered by GitHub Issue Mirror