New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix notice when generating documentation #18597
Conversation
Hm... this is weird. Logically the change makes fully sense. But it causes a lot tests to fail. Will try to investigate the reason for this. |
I guess the reason is this part: matomo/core/EventDispatcher.php Lines 108 to 111 in cf2572e
Before the method was returning I guess we need to move the |
Thinking more about that, I guess we could actually simply remove the |
I had a look for a whiel and I reckon this should be now fine to merge since we would install this plugin along with Matomo core. Versus before I think there could have been an issue that the log DB schema changes take some time (minutes, hours,days) to execute meaning it would have been in a state possibly where it's trying to activate and use the plugin but it's not finished installing yet. Then some of the events could have caused issues. This should no longer be an issue though since now the installation is always quick. LGTM 👍 |
fix a notice when generating the documentation when matomo is not installed.