Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add core updater with file access check #18594

Merged
merged 10 commits into from Jan 31, 2022
Merged

add core updater with file access check #18594

merged 10 commits into from Jan 31, 2022

Conversation

peterhashair
Copy link
Contributor

@peterhashair peterhashair commented Jan 10, 2022 •
edited

Description:

Fixes:#17054
add core updater directory permission check, before the update copy file is over. Update some Failed screenshots as well.

Review

add core updater with file access check
d95a6d0 
add core updater with file access check
@peterhashair peterhashair linked an issue Jan 10, 2022 that may be closed by this pull request
Prevent update installation failing because of selinux/file system protection result in an broken system. #17054
Closed
@peterhashair peterhashair added this to the 4.7.0 milestone Jan 10, 2022
@peterhashair peterhashair marked this pull request as ready for review January 10, 2022 02:33
@peterhashair peterhashair added the Needs Review PRs that need a code review label Jan 10, 2022
update screen shot
a9b0e12 
update screen shot
@peterhashair peterhashair added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jan 10, 2022
Peter Zhang and others added 4 commits January 10, 2022 17:08
Update en.json
8f77b12 
update to multiple support
@justinvelluppillai
Update plugins/CoreUpdater/Updater.php
3dfe966 
Co-authored-by: Justin Velluppillai <justin@innocraft.com>
@justinvelluppillai
Update plugins/CoreUpdater/Updater.php
4498c01 
Co-authored-by: Justin Velluppillai <justin@innocraft.com>
Update en.json
04353fd
Update en.json
aa241ba 
update wording
@justinvelluppillai
Copy link
Contributor

The english looks good 👍

@peterhashair peterhashair modified the milestones: 4.7.0, 4.8.0 Jan 18, 2022
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jan 25, 2022
@peterhashair peterhashair removed the Stale The label used by the Close Stale Issues action label Jan 25, 2022
@peterhashair
Copy link
Contributor Author

@sgiehl trying to think of a test, any suggestion?

@sgiehl
Copy link
Member

sgiehl commented Jan 30, 2022

Adding a test for that one was actually a bit harder than I expected. But I managed to add an UI test for it.

@sgiehl sgiehl removed the Needs Review PRs that need a code review label Jan 31, 2022
@sgiehl sgiehl merged commit ea3818a into 4.x-dev Jan 31, 2022
@sgiehl sgiehl deleted the m-17054-update-failing branch January 31, 2022 09:47
@sgiehl sgiehl mentioned this pull request Jan 31, 2022
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinvelluppillai justinvelluppillai justinvelluppillai left review comments

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.8.0
Development

Successfully merging this pull request may close these issues.

Prevent update installation failing because of selinux/file system protection result in an broken system.
3 participants
@peterhashair @justinvelluppillai @sgiehl