Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue] fixes #18578 better defaulting of date/period/segment in hash #18591

Merged
merged 7 commits into from Jan 10, 2022

Conversation

diosmosis
Copy link
Member

Description:

When changing the URL only set the hash date/period/segment when changing the URL if there are hash params specified. And also take into account params we are setting (for changing the URL only).

Review

@diosmosis diosmosis added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jan 7, 2022
@diosmosis diosmosis added this to the 4.7.0 milestone Jan 7, 2022
Copy link
Contributor

@peterhashair peterhashair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected

@peterhashair peterhashair linked an issue Jan 10, 2022 that may be closed by this pull request
@diosmosis diosmosis merged commit 67376ce into 4.x-dev Jan 10, 2022
@diosmosis diosmosis deleted the vue-fixes-tweaks branch January 10, 2022 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[VUE]Date selector doesn't change on report page.
2 participants