Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix random UI and javascript error #18585

Closed
wants to merge 4 commits into from
Closed

Conversation

peterhashair
Copy link
Contributor

Description:

Fix random UI and javascript error

Review

Peter and others added 4 commits January 7, 2022 14:16
remove plugins/Morpheus/javascripts/ajaxHelper.js
update ts error
@peterhashair
Copy link
Contributor Author

@sgiehl I think this #18525 PR is missing a ts-ignore. This PR should fix it. Still working on some screenshots.

@sgiehl
Copy link
Member

sgiehl commented Jan 7, 2022

@peterhashair simply defining the property also solves the issue. See https://github.com/matomo-org/matomo/pull/18587/files
My PR also already fixes some screenshots, so no need to do that twice....

@sgiehl sgiehl deleted the hotfix-random-ui-fix branch January 10, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants