Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] convert remaining usersmanager controllers to Vue #18584

Merged
merged 806 commits into from Feb 23, 2022
Merged

[Vue] convert remaining usersmanager controllers to Vue #18584

merged 806 commits into from Feb 23, 2022

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented Jan 6, 2022 •
edited

Description:

This PR is based off of #18583.

Changes:

  • Convert personal-settings controller and twig template parts to PersonalSettings.vue component and NewsletterSettings.vue component.
  • Convert anonymous-settings controller and twig template parts to AnonymousSettings.vue.

image

Review

@diosmosis
fix overlay test
d636b3d
@diosmosis
Merge branch 'vue-popover-handler' into vue-core-home-common-directives
e991934
@diosmosis
Merge branch '4.x-dev' into vue-corehome-components-1
2114167
@diosmosis
Merge branch 'vue-corehome-components-1' into vue-ajax-form
90196a8
@diosmosis
remove unintended changes
b94d66f
@diosmosis
remove unintended changes
4641557
@diosmosis
Merge branch 'vue-ajax-form' into vue-popover-handler
1212ffd
@diosmosis
Merge branch 'vue-popover-handler' into vue-core-home-common-directives
33303ac
@diosmosis
migrate archiving controller
8167767
@diosmosis
do not do a passthrough transpile of vue typescript, and fix many typ…
69d3440 
…escript errors in existing code
@diosmosis
more typescript fixes
3c0fff0
@diosmosis
even more fixes
1bd183e
@diosmosis
workarounds to fix recursive typing issues
b9fb003
@diosmosis
get corehome to build w/ full typescript build and output type defini…
5b53519 
…tions to local dir
@diosmosis
get outputted typings to be used when compiling other plugins and fix…
54ac1b1 
… typescript issues in CorePluginsAdmin
@diosmosis
readd corehome umd
0b84bf2
@diosmosis
fix typescript errors in ExampleVue plugin
eb610e4
@diosmosis
fix feedback typescript errors
adc7933
@diosmosis
Merge branch 'vue-no-passthrough-transpile' into vue-coreadminhome-ar…
8b41d38 
…chiving
@diosmosis
Merge branch '4.x-dev' into vue-corehome-components-1
7584a5d
@diosmosis
rebuild
55edfbd
@diosmosis
migrate branding controller and get to build
528f538
@diosmosis
fix issues and get to work
05e56bd
@diosmosis
rebuild
d23416c
@diosmosis
fix notification scroll
59eecd6
@diosmosis
migrate smtp settings controller in coreadminhome
f854475
@diosmosis
get to work
37e63aa
@diosmosis
migrate js tracking code generator and get to build
0d990c4
@diosmosis
migrate image tracking code generator and get to build
c089247
@diosmosis
get to work in UI
f9a2b33
@sgiehl
Copy link
Member

sgiehl commented Feb 8, 2022

@diosmosis guess this one is based on #18583, right?

@diosmosis
Copy link
Member Author

@sgiehl yes, added the missing bit to the description.

peterhashair
peterhashair reviewed Feb 10, 2022
View reviewed changes
Copy link
Contributor

@peterhashair peterhashair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of screenshots need an update.
#currentUserPassword is probably used twice on the user edit password page, maybe consider changing from id to class.
Other than that looks good to me.

@diosmosis diosmosis mentioned this pull request Feb 16, 2022
Closed
11 tasks
@peterhashair peterhashair removed the Needs Review PRs that need a code review label Feb 17, 2022
@diosmosis diosmosis mentioned this pull request Feb 23, 2022
Merged
11 tasks
@diosmosis diosmosis added the Needs Review PRs that need a code review label Feb 23, 2022
@diosmosis
Copy link
Member Author

@peterhashair fixed the build + maybe fixed a random test failure in matomo-org/plugin-CustomAlerts#109. ok to merge both?

@peterhashair
Copy link
Contributor

@diosmosis could be my cache. Still has the multiple HTML ID #currentUserPassword on one page. But other than that both looks good to me.

@diosmosis
Copy link
Member Author

@peterhashair that was there before so I didn't look into it, but I'll see if I can fix it now.

@peterhashair
Copy link
Contributor

@diosmosis right, don't waste too much time on it, it's not even an error just, warning, I will convert to a seperate issue.

@diosmosis
Copy link
Member Author

@peterhashair oh i just fixed it 👍

peterhashair
peterhashair approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@peterhashair peterhashair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once tests are passed, good to merge.

@peterhashair peterhashair merged commit 73c09aa into 4.x-dev Feb 23, 2022
@peterhashair peterhashair deleted the vue-usersmanager-6 branch February 23, 2022 04:56
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhashair peterhashair peterhashair approved these changes

Assignees
No one assigned
Labels
Do not close PRs with this label won't be marked as stale by the Close Stale Issues action Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.8.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@diosmosis @sgiehl @peterhashair @justinvelluppillai @bx80 @weblate