@diosmosis opened this Pull Request on January 6th 2022 Member

Description:

This PR is based off of https://github.com/matomo-org/matomo/pull/18583.

Changes:

  • Convert personal-settings controller and twig template parts to PersonalSettings.vue component and NewsletterSettings.vue component.
  • Convert anonymous-settings controller and twig template parts to AnonymousSettings.vue.

image

Review

@github-actions[bot] commented on February 2nd 2022 Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@sgiehl commented on February 8th 2022 Member

@diosmosis guess this one is based on #18583, right?

@diosmosis commented on February 8th 2022 Member

@sgiehl yes, added the missing bit to the description.

@diosmosis commented on February 23rd 2022 Member

@peterhashair fixed the build + maybe fixed a random test failure in https://github.com/matomo-org/plugin-CustomAlerts/pull/109. ok to merge both?

@peterhashair commented on February 23rd 2022 Contributor

@diosmosis could be my cache. Still has the multiple HTML ID #currentUserPassword on one page. But other than that both looks good to me.

@diosmosis commented on February 23rd 2022 Member

@peterhashair that was there before so I didn't look into it, but I'll see if I can fix it now.

@peterhashair commented on February 23rd 2022 Contributor

@diosmosis right, don't waste too much time on it, it's not even an error just, warning, I will convert to a seperate issue.

@diosmosis commented on February 23rd 2022 Member

@peterhashair oh i just fixed it :+1:

This Pull Request was closed on February 23rd 2022
Powered by GitHub Issue Mirror