Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate usersmanager root component to Vue #18583

Merged
merged 805 commits into from Feb 14, 2022
Merged

Migrate usersmanager root component to Vue #18583

merged 805 commits into from Feb 14, 2022

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented Jan 6, 2022

Description:

This PR is based off of #18582.

Changes:

  • Add support for bulk fetches to AjaxHelper.fetch.
  • Export v-tooltips directive + add default content transform.
  • Add lazyScrollToContent() function to matomo helper global.
  • Migrate matomo-users-management component to vue.

image

Review

@diosmosis diosmosis added Do not close PRs with this label won't be marked as stale by the Close Stale Issues action Needs Review PRs that need a code review and removed Stale The label used by the Close Stale Issues action labels Feb 3, 2022
@diosmosis diosmosis marked this pull request as ready for review February 3, 2022 15:12
Copy link
Contributor

@peterhashair peterhashair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably needs to update those failed screenshots, but other than that looks good to me.

@diosmosis diosmosis merged commit 4350dfb into 4.x-dev Feb 14, 2022
@diosmosis diosmosis deleted the vue-usersmanager-5 branch February 14, 2022 15:02
@justinvelluppillai justinvelluppillai changed the title [Vue] migrate usersmanager root component to Vue Migrate usersmanager root component to Vue Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do not close PRs with this label won't be marked as stale by the Close Stale Issues action Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants