Migrate paged users list component to vue #18582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…escript errors in existing code
…tions to local dir
… typescript issues in CorePluginsAdmin
diosmosis
added
Needs Review
peterhashair
reviewed
Feb 8, 2022
…ofill browser features/extensions
peterhashair
approved these changes
Feb 10, 2022
sgiehl
reviewed
Feb 11, 2022
| @@ -110,7 +110,7 @@ public function index() | |||
| ['key' => 'superuser', 'value' => Piwik::translate('Installation_SuperUser'), 'disabled' => true], | |||
| ]; | |||
| $view->filterAccessLevels = [ | |||
| ['key' => '', 'value' => Piwik::translate('UsersManager_ShowAll')], | |||
| ['key' => '', 'value' => ''], // show all | |||
There was a problem hiding this comment.
@diosmosis had you removed that one on purpose? If so I guess the translation key could be removed in en.json as well, as it doesn't seem to be used anywhere else.
There was a problem hiding this comment.
Yes it was removed on purpose, otherwise there is both "Show All" and a placeholder, but after selecting "Show All" there's no way to show the placeholder again, so a user might forget what the field was for. Will remove the translation in a PR.
justinvelluppillai
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR is based off of #18576.
Changes:
Review