Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VUE]Date selector doesn't change on report page. #18578

Closed
peterhashair opened this issue Jan 6, 2022 · 1 comment · Fixed by #18591
Closed

[VUE]Date selector doesn't change on report page. #18578

peterhashair opened this issue Jan 6, 2022 · 1 comment · Fixed by #18591
Assignees
@diosmosis
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
4.7.0

Comments

@peterhashair
Copy link
Contributor

peterhashair commented Jan 6, 2022 •
edited

Expected Behavior

I guess there is a regression there. Under admin->Personal->Email Reports. if you change the date selector the UI doesn't change, but the param changes.

Current Behavior

image
See the screenshot, the date selector is 2021-01-04, but the URL param is 2021-01-05

Possible Solution

Steps to Reproduce (for Bugs)

Context

Your Environment

  • Matomo Version:
  • PHP Version:
  • Server Operating System:
  • Additionally installed plugins:
  • Browser:
  • Operating System:
@peterhashair peterhashair added Regression Indicates a feature used to work in a certain way but it no longer does even though it should. Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Jan 6, 2022
@sgiehl
Copy link
Member

sgiehl commented Jan 7, 2022

The problem actually seems to be, that the admin interface still works without a url hash, but changing the date in the selector appends/updates the date param in the url hash and not in the normal url parameters.
I Matomo 4.5 the url parameter was updated instead. So this is a regression indeed.

@sgiehl sgiehl removed the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Jan 7, 2022
@sgiehl sgiehl added this to the 4.7.0 milestone Jan 7, 2022
diosmosis added a commit that referenced this issue Jan 7, 2022
@diosmosis
fix #18578, do not add default hash params if no hash params being set
4e1c2cc
@peterhashair peterhashair linked a pull request Jan 10, 2022 that will close this issue
[Vue] fixes #18578 better defaulting of date/period/segment in hash #18591
Merged
11 tasks
diosmosis added a commit that referenced this issue Jan 10, 2022
@diosmosis
[Vue] fixes #18578 better defaulting of date/period/segment in hash (#…
67376ce 
…18591)

* remove unneeded file

* remove file from CoreHome.php

* fix #18578, do not add default hash params if no hash params being set

* better fix

* even better fix, take into account the params being changed to

* simpler fix, hash params will overwrite anyway no need to || them

* fix tests
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diosmosis diosmosis

Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.7.0
Development

Successfully merging a pull request may close this issue.

[Vue] fixes #18578 better defaulting of date/period/segment in hash matomo-org/matomo
4 participants
@diosmosis @justinvelluppillai @sgiehl @peterhashair