Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unifont import, TCPDF use import fonts #18577

Merged
merged 2 commits into from Jan 11, 2022
Merged

unifont import, TCPDF use import fonts #18577

merged 2 commits into from Jan 11, 2022

Conversation

peterhashair
Copy link
Contributor

Description:

Fixes: #18465
if unifont import, use that font for the pdf

Review

if unifont import, use that font for the pdf
59fa071 
if unifont import, use that font for the pdf
@peterhashair peterhashair added this to the 4.7.0 milestone Jan 6, 2022
@peterhashair peterhashair added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Jan 6, 2022
bx80
bx80 approved these changes Jan 9, 2022
View reviewed changes
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, the unifont was detected and applied to email reports 👍

Update Pdf.php
9471d81 
update function and comments
@peterhashair peterhashair merged commit a0750b0 into 4.x-dev Jan 11, 2022
@peterhashair peterhashair deleted the m-18465-font-report branch January 11, 2022 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinvelluppillai justinvelluppillai justinvelluppillai left review comments

@bx80 bx80 bx80 approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.

daily report does not support unicode characters
3 participants
@peterhashair @justinvelluppillai @bx80