Migrate user edit form directive to Vue component #18576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d new polyfill + try to fix random test failure
…arJsAdapter better
diosmosis
force-pushed
the
vue-usersmanager-3
branch
from
9fd5467
to
0546314
Compare
11 tasks
There was a problem hiding this comment.
Looks good to me, just an error on the checkFilesDoNotHaveWeirdSpaces.
plugins/UsersManager/vue/dist/UsersManager.umd.js contains an unusual space character, please remove it from here: ...Node"])("p", null, " ", -1);
I think is here cause of the error, fixed in here #18527 about to merge.
|
@peterhashair found a way to ignore |
|
Updated screenshots, since the |
justinvelluppillai
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR is based off of #18572.
Changes:
Review