Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move unsupported Browser check before create session #18575

Merged
merged 4 commits into from Jan 12, 2022
Merged

move unsupported Browser check before create session #18575

merged 4 commits into from Jan 12, 2022

Conversation

peterhashair
Copy link
Contributor

Description:

Fixes: #18560
move unsupported Browser before creating auth session

Review

Update FrontController.php
8575148 
move unsupported Browser before create session
@peterhashair peterhashair added this to the 4.7.0 milestone Jan 6, 2022
@peterhashair peterhashair marked this pull request as ready for review January 10, 2022 20:19
@peterhashair peterhashair added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Jan 10, 2022
sgiehl
sgiehl requested changes Jan 11, 2022
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment. Besides that it should be good to merge

core/FrontController.php Outdated Show resolved Hide resolved
@sgiehl sgiehl removed the Needs Review PRs that need a code review label Jan 11, 2022
@peterhashair peterhashair merged commit cfc3b46 into 4.x-dev Jan 12, 2022
@peterhashair peterhashair deleted the m-18560-session-on-unsupport-brower branch January 12, 2022 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl requested changes

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.

Do not create a session if accessing login page with a not supported browser
2 participants
@peterhashair @sgiehl