Migrate user-permissions-edit component to vue #18572
Conversation
There was a problem hiding this comment.
overall looks good to me, just one thing, not sure we need to fix it, when saving details after the password confirm modal appears, the autofill password plugin will change the email field in the background to an auto-filled username, which will lead to an error.
Maybe the confirm popup appears in background fields should be read-only to prevent auto-fill.
|
@peterhashair by "autofill password plugin" do you mean a matomo plugin or a browser extension? Can you provide a link to it? |
|
@diosmosis browser extension. Like bitwarden or chrome password autofill. I think it trying to fill 2 fields, username, password. The popup only has the password field, so it changed the field behind the popup confirm. |
|
@peterhashair that's interesting, thanks, I'll disable the inputs as you suggest. |
|
@peterhashair fixed in #18576 where the relevant angularjs code is migrated |
justinvelluppillai
changed the title
Description:
This PR is based off of #18566.
Changes:
Review