Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate capabilities edit component to Vue #18566

Merged
merged 721 commits into from Feb 7, 2022
Merged

Migrate capabilities edit component to Vue #18566

merged 721 commits into from Feb 7, 2022

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented Jan 4, 2022 •
edited

Description:

This PR is based off of #18564.

Changes:

  • Create CapabilityStore for permissions metadata service.
  • Migrate capability edit component to vue component.

image

Review

@diosmosis
Merge branch 'vue-period-selector-regression' into vue-reporting-menu
77cd692
@diosmosis
rebuild vue
fbfbf89
@diosmosis
Merge branch 'vue-reporting-menu' into vue-widget-loader
99d5c5f
@diosmosis
use correct variable
2b1177b
@diosmosis
rebuild vue
90ef0e8
@diosmosis
Merge branch 'vue-period-selector-regression' into vue-reporting-menu
1c6d117
@diosmosis
Merge branch 'vue-reporting-menu' into vue-widget-loader
f00ce31
@diosmosis
fix widget url logic
16c2573
@diosmosis
segment parameter can be undefined now for some reason
265362d
@diosmosis
fix ngmodel binding in siteselector adapter (for last time hopefully)
fd4e220
@diosmosis
the original site selector only set the first site to the first site …
8affb84 
…in the initial sites query if there was only one site in the entire matomo instance
@diosmosis
fix sitesmanager ui test failure
2206ae6
@diosmosis
fix usersettings test failure
ee6de95
@diosmosis
rebuild vue
e5b31c4
@diosmosis
Merge branch 'vue-reporting-menu' into vue-widget-loader
8eba658
@diosmosis
more siteselector tweaks.
b64eddf
@diosmosis
build CoreHome
97876dd
@diosmosis
more siteselector tweaks.
c7a17d6
@diosmosis
another siteselector issue
ad41d70
@diosmosis
update screenshots
69b69db
@diosmosis
Merge branch 'vue-reporting-menu' into vue-widget-loader
5fd728b
@diosmosis
Merge branch 'vue-widget-loader' into vue-widget
bd0dca4
@diosmosis
Merge branch 'vue-widget' into vue-reporting-page
b0e01c0
@diosmosis
update screenshot and try to fix random failure
6345c8e
@diosmosis
Merge branch 'vue-reporting-menu' into vue-widget-loader
7d865ed
@diosmosis
fix some issues in widget.vue when containerid is specified
262b3d7
@diosmosis
fix couple tests
0f1003a
@diosmosis
Merge branch 'vue-widget-loader' into vue-widget
39c772b
@diosmosis
fix several test failures
9f369a4
@diosmosis
Merge branch 'vue-widget' into vue-reporting-page
23b148c
@diosmosis diosmosis marked this pull request as ready for review January 22, 2022 10:28
@diosmosis diosmosis added the Needs Review PRs that need a code review label Jan 22, 2022
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jan 30, 2022
@diosmosis diosmosis added Do not close PRs with this label won't be marked as stale by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Jan 30, 2022
sgiehl and others added 16 commits January 31, 2022 15:33
@sgiehl
Merge branch '4.x-dev' into vue-sitesmanager
13749b5
@diosmosis
in groupedsetting handle templateFile property for angularjs BC
e49093e
@diosmosis
rebuild vue
8d15fb6
@diosmosis
Merge branch 'vue-sitesmanager' into vue-sitesmanager-2
2dcb52a
@diosmosis
fix view tracking code link
d985e5d
@diosmosis
Merge branch 'vue-sitesmanager' into vue-sitesmanager-2
0d37707
@diosmosis
Merge branch 'vue-sitesmanager-2' into vue-users-manager-1
8ca3e57
@diosmosis
git Merge branch '4.x-dev' into vue-sitesmanager
7020e70
@diosmosis
Merge branch 'vue-sitesmanager' into vue-sitesmanager-2
327ea29
@diosmosis
Merge branch 'vue-sitesmanager-2' into vue-users-manager-1
c0882f7
@diosmosis
Merge branch '4.x-dev' into vue-sitesmanager-2
349eaaa
@diosmosis
Merge branch 'vue-sitesmanager-2' into vue-users-manager-1
138278b
@diosmosis
Update screenshot.
806b426
@diosmosis
Merge branch 'vue-sitesmanager-2' into vue-users-manager-1
1eb7c0a
@diosmosis
update screenshot
c2499c6
@diosmosis
Merge branch 'vue-sitesmanager-2' into vue-users-manager-1
f698a6f
sgiehl
sgiehl approved these changes Feb 7, 2022
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Couldn't find any issue around that.

@sgiehl sgiehl merged commit 1dd8569 into 4.x-dev Feb 7, 2022
@sgiehl sgiehl deleted the vue-users-manager-1 branch February 7, 2022 15:49
@justinvelluppillai justinvelluppillai changed the title [Vue] migrate capabilities edit component Migrate capabilities edit component to Vue Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Do not close PRs with this label won't be marked as stale by the Close Stale Issues action Needs Review PRs that need a code review
Projects
None yet
Milestone
4.8.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@diosmosis @sgiehl @bx80 @weblate