New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate sitesmanager controller and twig templates to Vue components #18564
Conversation
…in the initial sites query if there was only one site in the entire matomo instance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peterhashair if I understand correctly this should be fixed w/ the latest merge |
cc3be90
to
0d37707
Compare
@diosmosis just had another look it seems the Roll-up still missing some parts. Do I need to merge another PR before this one? |
@peterhashair it looks the same to me on this branch as it does on 4.x-dev. What is missing for you? |
@diosmosis I think some of the premium plugins append additional fields to the Site Manager. The first video is the current PR. The second is the 4.x-dev screen-capture.mp4expected.mp4 |
@peterhashair this is what I see locally on this branch: Can you pull, rebuild and clear your cache? |
@diosmosis ah, I did all those, but still no luck. I guess it may be some package missing. Will try more build. |
@diosmosis another issue that might be good to fix in that one:
|
@sgiehl it seems like the existing code was meant to hide the top button bar while a site is being edited/added, but it doesn't really work. I made it work and changed it to disable the bar while a site is being edited/added since it looked odd to simply remove it. Allowing multiple add modals seemed more complicated. |
@diosmosis hiding the button to add another one sounds fine as well 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had another quick look through the code and the UI. Seems to work as expected.
Description:
This PR is based off of #18562.
Changes:
Review