@diosmosis opened this Pull Request on January 4th 2022 Member

Description:

This PR is based off of #18562.

Changes:

  • Make MatomoUrl.urlQuery/hashQuery public readonly so they can be watched.
  • Create ManageGlobalSettings vue component.
  • Create SiteManagement vue component.
  • related changes.

image

Review

@github-actions[bot] commented on January 30th 2022 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@diosmosis commented on February 1st 2022 Member

@peterhashair if I understand correctly this should be fixed w/ the latest merge

@peterhashair commented on February 2nd 2022 Contributor

@diosmosis just had another look it seems the Roll-up still missing some parts. Do I need to merge another PR before this one?

@diosmosis commented on February 2nd 2022 Member

@peterhashair it looks the same to me on this branch as it does on 4.x-dev. What is missing for you?

@peterhashair commented on February 2nd 2022 Contributor

@diosmosis I think some of the premium plugins append additional fields to the Site Manager. The first video is the current PR. The second is the 4.x-dev

https://user-images.githubusercontent.com/3783072/152099966-80b56ca9-1f9a-42e2-a6d7-bd791ac3acc5.mp4

https://user-images.githubusercontent.com/3783072/152100431-88ce6add-23ca-4375-86ae-913e0f4a0365.mp4

@diosmosis commented on February 2nd 2022 Member

@peterhashair this is what I see locally on this branch:

(adding)
localhost_index php_module=SitesManager action=index idSite=1 period=range date=previous30

(editing)
localhost_index php_module=SitesManager action=index idSite=1 period=range date=previous30 (1)

Can you pull, rebuild and clear your cache?

@peterhashair commented on February 2nd 2022 Contributor

@diosmosis ah, I did all those, but still no luck. I guess it may be some package missing. Will try more build.

@sgiehl commented on February 2nd 2022 Member

@diosmosis another issue that might be good to fix in that one:

  • It's possible to open the form for adding a measurable multiple times. But clicking a cancel button closes all of them at once. Imho we should simply close the previous form before opening a new one
@diosmosis commented on February 2nd 2022 Member

@sgiehl it seems like the existing code was meant to hide the top button bar while a site is being edited/added, but it doesn't really work. I made it work and changed it to disable the bar while a site is being edited/added since it looked odd to simply remove it.

Allowing multiple add modals seemed more complicated.

@sgiehl commented on February 2nd 2022 Member

@diosmosis hiding the button to add another one sounds fine as well 👍

This Pull Request was closed on February 7th 2022
Powered by GitHub Issue Mirror