@diosmosis opened this Pull Request on January 3rd 2022 Member

Description:

This PR is based off of https://github.com/matomo-org/matomo/pull/18553.

Changes:

  • Fix typing error in SiteSelector.
  • Convert sites-manager-site.controller.js to SiteFields.vue component.
  • Add stores for timezone/currency/site type for use in SitesManager.
  • Created lazyInitSingleton function that constructs a singleton when it is first accessed so we don't end up sending a bunch of ajax requests on page load for stores that may not be used.

Review

@sgiehl commented on January 21st 2022 Member

Here a few issues found while clicking through the UI. Some might possibly be unrelated to the changes here.
Only did some quick testing yet. Maybe something else pops up when I continue the review...

  • [ ] When adding a new site the cancel button does not work
  • [ ] When searching for a site has exactly 10 results the next button is clickable (even though there aren't any further results)
@diosmosis commented on January 22nd 2022 Member

When searching for a site has exactly 10 results the next button is clickable (even though there aren't any further results)

This is a problem w/ 4.x-dev. It can be fixed easily but better to wait for these fixes until the next PR since the fix would still be in the angularjs code here.

@diosmosis commented on January 22nd 2022 Member

When adding a new site the cancel button does not work

Fixed.

Powered by GitHub Issue Mirror