New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vue] convert sites manager single site template/controller to vue component #18562
Conversation
… reusable function to create vue app and add globals to it
…red when clearing transient notifications
Here a few issues found while clicking through the UI. Some might possibly be unrelated to the changes here.
|
This is a problem w/ 4.x-dev. It can be fixed easily but better to wait for these fixes until the next PR since the fix would still be in the angularjs code here. |
Fixed. |
@diosmosis Adding a rollup doesn't work with the changes here. The field for selecting the sites isn't displayed without any error. It works on 4.x-dev, so seems to be related to the changes here. Can you check if we can get that running again without changes in the RollUp plugin? |
@sgiehl should be fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found some more issues:
- When adding a new site, it automatically added at the top of the list. But the currency and timezone is always empty for those new sites:
When editing a site the display values in the list are also not updated.
Besides that it looks fine and should be good to merge, once those issues are fixed.
This is broken on 4.x-dev too. It should be fixed in the next PR.
Fixed. |
Description:
This PR is based off of #18553.
Changes:
Review