Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not create a session if accessing login page with a not supported browser #18560

Closed
tsteur opened this issue Jan 2, 2022 · 0 comments · Fixed by #18575
Closed

Do not create a session if accessing login page with a not supported browser #18560

tsteur opened this issue Jan 2, 2022 · 0 comments · Fixed by #18575
Assignees
Labels
c: Performance For when we could improve the performance / speed of Matomo.
Milestone

Comments

@tsteur
Copy link
Member

tsteur commented Jan 2, 2022

When accessing the login page with a not supported browser like IE11, can we not create a session? This can prevent some issues where unneeded extra sessions are created. Seeing https://github.com/matomo-org/matomo/blob/4.6.2/core/FrontController.php#L426-L428 is checked after the session was created maybe? If easily doable, be great to move this check a wee bit further up before makeSessionAuthenticator so that when using an old browser, then no new entry in the session table is created.

@tsteur tsteur added the c: Performance For when we could improve the performance / speed of Matomo. label Jan 2, 2022
@tsteur tsteur added this to the 4.7.0 milestone Jan 2, 2022
@peterhashair peterhashair self-assigned this Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Performance For when we could improve the performance / speed of Matomo.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants