Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue] migrate trackingfailures directive to Vue #18553

Merged
merged 643 commits into from Jan 18, 2022

Conversation

diosmosis
Copy link
Member

Description:

This PR is based off of #18552.

Changes:

  • Migrate tracking failures directive to Vue.

Review

@diosmosis diosmosis added the Needs Review PRs that need a code review label Jan 12, 2022
@diosmosis diosmosis marked this pull request as ready for review January 12, 2022 05:52
@sgiehl sgiehl modified the milestones: 4.7.0, 4.8.0 Jan 18, 2022
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work as expected.

@sgiehl sgiehl merged commit 0e730b7 into 4.x-dev Jan 18, 2022
@sgiehl sgiehl deleted the vue-coreadminhome-trackingfailures branch January 18, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants