@diosmosis opened this Pull Request on December 30th 2021 Member

Description:

This PR is based off of https://github.com/matomo-org/matomo/pull/18549.

Changes:

  • Migrate the js tracking code generator controller and twig content.
  • Migrate the image tracking code generator controller and twig content.
  • Add some extra exports to CoreHome.

Review

@sgiehl commented on January 12th 2022 Member

While clicking through the UI I found one minor issue. Not sure if that was the case before, but I guess it should be easy to fix:

When you choose a goal for image tracking and afterwards switch the site in the selector to a site where a goal with that id doesn't exist, the goal selector switches to None, but the tracking code still includes idGoal=x for the previously selected goal.

@diosmosis commented on January 12th 2022 Member

When you choose a goal for image tracking and afterwards switch the site in the selector to a site where a goal with that id doesn't exist, the goal selector switches to None, but the tracking code still includes idGoal=x for the previously selected goal.

Should be fixed.

@diosmosis commented on January 13th 2022 Member

@sgiehl should be fixed

This Pull Request was closed on January 13th 2022
Powered by GitHub Issue Mirror