Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] migrate smtp controller in coreadminhome #18549

Merged
merged 624 commits into from Jan 12, 2022
Merged

[Vue] migrate smtp controller in coreadminhome #18549

merged 624 commits into from Jan 12, 2022

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented Dec 29, 2021 •
edited

Description:

This PR is based off of #18548.

Changes:

  • Migrate the smtp controller in CoreAdminHome + it's associated twig template part.

image

Review

@diosmosis
fix another set of issues
0ca2df5
@diosmosis
fix another issue
82382d4
@diosmosis
rebuild vue
8b64ffa
@diosmosis
Merge branch '4.x-dev' into vue-form-field
50ce86a
@diosmosis
Merge branch 'vue-form-field' into vue-reporting-menu
72d3bae
@diosmosis
better ng-change/ng-model fix
e3bedbe
@diosmosis
Merge branch 'vue-form-field' into vue-reporting-menu
2b01d90
@diosmosis
Merge branch 'vue-form-field' into vue-period-selector
5a751c5
@diosmosis
update some screenshots
078472d
@diosmosis
rebuild vue
e0a2338
@diosmosis
Merge branch 'vue-period-selector' into vue-reporting-pages-model
abec781
@diosmosis
Merge branch 'vue-reporting-pages-model' into vue-reporting-menu
526df55
@diosmosis
remove some TODOs
4067686
@diosmosis
initiate initial ng-change ONLY for site selectors where this behavio…
303fcf4 
…r applies
@diosmosis
Merge branch 'vue-form-field' into vue-period-selector
00438ad
@diosmosis
Merge branch 'vue-period-selector' into vue-reporting-pages-model
700eeed
@diosmosis
Merge branch 'vue-reporting-pages-model' into vue-reporting-menu
c2fb339
@diosmosis
Merge branch 'vue-reporting-menu' into vue-widget-loader
5101693
@diosmosis
emit/broadcast on correct scope in wrapper
cb0441a
@diosmosis
rebuild vue
2991433
@diosmosis
Merge branch '4.x-dev' into vue-period-selector
6d33299
@diosmosis
Merge branch 'vue-period-selector' into vue-reporting-pages-model
4833261
@diosmosis
Merge branch 'vue-reporting-pages-model' into vue-reporting-menu
2ec6bf7
@diosmosis
Merge branch 'vue-reporting-menu' into vue-widget-loader
00aac86
@diosmosis
Merge branch 'next_release' into vue-widget-loader
1e0ecfa
@diosmosis
Merge branch 'vue-post-event-regression' into vue-widget-loader
2519f24
@diosmosis
fix some issues
5546f95
@diosmosis
Merge branch 'vue-widget-loader' into vue-widget
6497ead
@diosmosis
couple more fixes
6e56c3c
@diosmosis
fix another title issue
cc0b4fb
@diosmosis
update screenshots
579c883
@diosmosis
Merge branch 'vue-ajax-form' into vue-popover-handler
d71f6cd
@diosmosis
Merge branch 'vue-popover-handler' into vue-core-home-common-directives
693655c
@diosmosis
Merge branch 'vue-core-home-common-directives' into vue-no-passthroug…
25ac446 
…h-transpile
@diosmosis
update screenshot
1abec64
@diosmosis
fix tests
b0ef67c
@diosmosis
rebuild
3a4fd1e
@diosmosis
Merge branch 'vue-no-passthrough-transpile' into vue-coreadminhome-ar…
5d313e0 
…chiving
@diosmosis
rebuild
85acf01
@diosmosis
order plugins by dependencies in vue:build and fix warning in corehom…
8aed53b 
…e build
@diosmosis
Merge branch 'vue-no-passthrough-transpile' into vue-coreadminhome-ar…
1a0c856 
…chiving
@diosmosis
Merge branch '4.x-dev' into vue-no-passthrough-transpile
4d4d771
@diosmosis
Merge branch 'vue-no-passthrough-transpile' into vue-coreadminhome-ar…
9024d34 
…chiving
@diosmosis
Merge branch 'vue-coreadminhome-archiving' into vue-coreadminhome-bra…
f58faf4 
…nding
@diosmosis
Merge branch 'vue-coreadminhome-branding' into vue-coreadminhome-smtp
eaddda4
@diosmosis
built vue files
03f05ca
@diosmosis
fix bug and rebuild
a588285
@diosmosis
fix bug and rebuild
3b04483
@diosmosis
fix issue
3936563
@diosmosis
Merge branch '4.x-dev' into vue-coreadminhome-archiving
90204e7
@diosmosis
Merge branch 'vue-coreadminhome-archiving' into vue-coreadminhome-bra…
d672d19 
…nding
@diosmosis
Merge branch 'vue-coreadminhome-branding' into vue-coreadminhome-smtp
1329b01
@diosmosis diosmosis marked this pull request as ready for review January 11, 2022 03:36
@diosmosis diosmosis added the Needs Review PRs that need a code review label Jan 11, 2022
peterhashair
peterhashair approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@peterhashair peterhashair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@diosmosis diosmosis merged commit 878722f into 4.x-dev Jan 12, 2022
@diosmosis diosmosis deleted the vue-coreadminhome-smtp branch January 12, 2022 03:06
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhashair peterhashair peterhashair approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@diosmosis @peterhashair @justinvelluppillai @bx80 @weblate