@peterhashair opened this Pull Request on December 28th 2021 Contributor

Description:

Fixes: #18537
remove strong type on SendFeedbackForFeature function

Review

@github-actions[bot] commented on January 5th 2022 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@sgiehl commented on January 6th 2022 Member

@justinvelluppillai @peterhashair didn't you see that the vue build action failed for this PR due to some code formatting issues? Would be good to always check that before merging, as now the action fails for all PRs after merging in latest changes...
We maybe should consider to require this action to pass for a PR to be mergeable.

@justinvelluppillai commented on January 6th 2022 Contributor

@sgiehl sorry missed that - yes certainly the build should always be required to pass at least before merging.

@sgiehl commented on January 6th 2022 Member

I have pushed a fix here: https://github.com/matomo-org/matomo/pull/18525/
Will merge the PR soon, so it will be fixed on 4.x-dev as well.

@peterhashair commented on January 6th 2022 Contributor

@sgiehl yes, sorry, I forgot to update the VUE format.

This Pull Request was closed on January 6th 2022
Powered by GitHub Issue Mirror