@diosmosis
Description:
Fixes #18539
Deep watching for properties in an object property doesn't seem to work in FormField, and it's not particularly performant, so removing the allSettings property from Vue. It may be better in the long run to move this functionality further up the component tree also (instead of FormFIeld doing v-show=showThisField, we have <FormField v-show=shouldShow>).
Changes:
- Remove allSettings property from FormField.vue and just make the condition function handle that.
- Support deep watching in angularjs adapter where it works.
- In FieldTextAreaArray, check if ref is set before using it. Think this only happens in error states, but should still be useful to have it I guess.
Review
- [ ] Functional review done
- [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- [ ] Security review done
- [ ] Wording review done
- [ ] Code review done
- [ ] Tests were added if useful/possible
- [ ] Reviewed for breaking changes
- [ ] Developer changelog updated if needed
- [ ] Documentation added if needed
- [ ] Existing documentation updated if needed
@Swansoffie02
Description:
Fixes #18539
Deep watching for properties in an object property doesn't seem to work in FormField, and it's not particularly performant, so removing the allSettings property from Vue. It may be better in the long run to move this functionality further up the component tree also (instead of FormFIeld doing
v-show=showThisField, we have<FormField v-show=shouldShow>).Changes:
- Remove allSettings property from FormField.vue and just make the condition function handle that.
- Support deep watching in angularjs adapter where it works.
- In FieldTextAreaArray, check if ref is set before using it. Think this only happens in error states, but should still be useful to have it I guess.
Review
- [x] Functional review done
- [x] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- [x] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- [x] Security review done
- [x] Wording review done
- [x] Code review done
- [x] Tests were added if useful/possible
- [x] Reviewed for breaking changes
- [x] Developer changelog updated if needed
- [x] Documentation added if needed
- [x] Existing documentation updated if needed