@diosmosis opened this Pull Request on December 24th 2021 Member

Description:

Fixes #18539

Deep watching for properties in an object property doesn't seem to work in FormField, and it's not particularly performant, so removing the allSettings property from Vue. It may be better in the long run to move this functionality further up the component tree also (instead of FormFIeld doing v-show=showThisField, we have <FormField v-show=shouldShow>).

Changes:

  • Remove allSettings property from FormField.vue and just make the condition function handle that.
  • Support deep watching in angularjs adapter where it works.
  • In FieldTextAreaArray, check if ref is set before using it. Think this only happens in error states, but should still be useful to have it I guess.

Review

@Swansoffie02 commented on December 30th 2021

Description:

Fixes #18539

Deep watching for properties in an object property doesn't seem to work in FormField, and it's not particularly performant, so removing the allSettings property from Vue. It may be better in the long run to move this functionality further up the component tree also (instead of FormFIeld doing v-show=showThisField, we have <FormField v-show=shouldShow>).

Changes:

  • Remove allSettings property from FormField.vue and just make the condition function handle that.
  • Support deep watching in angularjs adapter where it works.
  • In FieldTextAreaArray, check if ref is set before using it. Think this only happens in error states, but should still be useful to have it I guess.

Review

This Pull Request was closed on December 30th 2021
Powered by GitHub Issue Mirror