@peterhashair opened this Pull Request on December 24th 2021 Contributor

Description:

L3: https://innocraft.atlassian.net/browse/L3-199
fix error no data notification.
Show on the campaign with data show.
To reproduce it, need to select a period, and require a segment. The request is that one, in my case.

segment=visitorType==returning&date=2021-09-01,2021-09-15&module=MarketingCampaignsReporting&format=html&action=getGroup&period=range&idSite=1&widget=&showtitle=1&random=2789 

The code runs into here https://github.com/matomo-org/matomo/blob/1aec00ff0affa727ef134e230b465091b97e6863/core/DataAccess/ArchiveSelector.php#L102-L107

Review

@github-actions[bot] commented on January 1st 2022 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@peterhashair commented on January 6th 2022 Contributor

@bx80 if I am right, I remember the problem was, there are multiple javascript ajax calling this function https://github.com/matomo-org/matomo/blob/9ed7e1815e263aa8a1a52332311ba0fd3489bb01/plugins/SegmentEditor/SegmentEditor.php#L186
If one of the ajax returns an empty result, the no data message will show up. In my case is the Campaign Groups, which is no data is expected, but the segment is processed as an archive.

@bx80 commented on January 7th 2022 Contributor

@peterhashair That makes sense when considering the multiple ajax calls. I can't really think of any scenario where there would be a reason to show the no data (check back later) message when we know that an archive has already been generated for the segment. Just wanted to be sure we're not preventing the message being shown when it is needed. :slightly_smiling_face:

This Pull Request was closed on January 7th 2022
Powered by GitHub Issue Mirror