Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Field conditions eg in Measurable Settings API not working anymore #18539

Closed
tsteur opened this issue Dec 24, 2021 · 1 comment · Fixed by #18542
Closed

Field conditions eg in Measurable Settings API not working anymore #18539

tsteur opened this issue Dec 24, 2021 · 1 comment · Fixed by #18542
Assignees
@diosmosis
Labels
Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
4.7.0

Comments

@tsteur
Copy link
Member

tsteur commented Dec 24, 2021

Seems to work in 4.6.2 but not on 4.x-dev or on demo2.

eg go to https://demo2.matomo.org/index.php?module=SitesManager&action=index&idSite=13&period=day&date=yesterday and edit a site/measurable.

Then click on Disable visits log & visitor profile. When enabled, it should hide the second setting which it no longer does.

image

Noticed this in some other plugin that it seems to no longer work. Maybe a regression in Vue ?

ping @diosmosis

putting it for now as a regression in 4.7 but happy can move it out if it's not a regression.
@tsteur tsteur added Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Dec 24, 2021
@tsteur tsteur added this to the 4.7.0 milestone Dec 24, 2021
@diosmosis
Copy link
Member

It's probably a regression, will look into it.

@diosmosis diosmosis mentioned this issue Dec 24, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diosmosis diosmosis

Labels
Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.7.0
Development

Successfully merging a pull request may close this issue.

[Vue] remove support in vue for FormField.allSettings matomo-org/matomo
2 participants
@diosmosis @tsteur