Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove compareDates with comparePeriods when adding new segment #18535

Merged
merged 1 commit into from Jan 7, 2022
Merged

remove compareDates with comparePeriods when adding new segment #18535

merged 1 commit into from Jan 7, 2022

Conversation

diosmosis
Copy link
Member

Description:

Found this bug when looking at #18534.

To reproduce:

  1. compare a period w/o a segment loaded
  2. add a new segment
  3. look at the URL, there will be compareDates[] but not comparePeriods[], which will cause API requests to fail

Review

@diosmosis diosmosis added the Bug For errors / faults / flaws / inconsistencies etc. label Dec 23, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2022

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jan 7, 2022
@diosmosis diosmosis added Do not close PRs with this label won't be marked as stale by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Jan 7, 2022
@sgiehl sgiehl added this to the 4.7.0 milestone Jan 7, 2022
@sgiehl sgiehl merged commit 57cd4a4 into 4.x-dev Jan 7, 2022
@sgiehl sgiehl deleted the new-segment-comp-change-bug-fix branch January 7, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. Do not close PRs with this label won't be marked as stale by the Close Stale Issues action
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @sgiehl