Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change rearchive end date from yesterday to today #18523

Merged
merged 3 commits into from Jan 12, 2022

Conversation

bx80
Copy link
Contributor

@bx80 bx80 commented Dec 19, 2021

Description:

Fixes #18344

Re-archiving reports uses yesterday as the end date of the date range to re-archive, this can cause data from yesterday to not be re-archived if daily archiving has already taken place. Changing the default end date from yesterday to today fixes this.

This PR copies the fix by @tsteur and will add any test fixes required.

Review

@bx80 bx80 added Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Dec 19, 2021
@bx80 bx80 added this to the 4.7.0 milestone Dec 19, 2021
@bx80 bx80 added the Needs Review PRs that need a code review label Dec 20, 2021
@bx80 bx80 self-assigned this Dec 20, 2021
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Dec 28, 2021
@sgiehl sgiehl removed Needs Review PRs that need a code review Stale The label used by the Close Stale Issues action labels Jan 12, 2022
@sgiehl sgiehl merged commit fe255ed into 4.x-dev Jan 12, 2022
@sgiehl sgiehl deleted the m-18344-rearchiving-skips-yesterday branch January 12, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change rearchive end date from yesterday to today so it processes the last day correctly
2 participants