Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move tracking code below website selector #18522

Merged
merged 2 commits into from Dec 20, 2021
Merged

move tracking code below website selector #18522

merged 2 commits into from Dec 20, 2021

Conversation

peterhashair
Copy link
Contributor

@peterhashair peterhashair commented Dec 19, 2021 •
edited

Description:

Fixes: #18521
move tracking code below website selector

Review

Peter Zhang added 2 commits December 20, 2021 12:09
Update trackingCodeGenerator.twig
3c3fb5e 
move tracking code below website selector
Update UIIntegrationTest_admin_manage_tracking_code.png
d0ec676 
update website selector
@peterhashair peterhashair added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Dec 20, 2021
@sgiehl sgiehl added this to the 4.7.0 milestone Dec 20, 2021
@sgiehl sgiehl merged commit 354c84d into 4.x-dev Dec 20, 2021
@sgiehl sgiehl deleted the m-18521-add-tracking-code-page branch December 20, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.

Tracking code page: Move JavaScript tracking code right after the website
2 participants
@peterhashair @sgiehl