Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter metadata API response only when the test is executed for allowed metadata API #18510

Merged
merged 1 commit into from Dec 16, 2021

Conversation

AltamashShaikh
Copy link
Contributor

Filter metadata API response only when the test is executed for allowed metadata API

Description:

The previous code changes added to filter metadata response was breaking other API tests like API.get which internally tries to call API.getSegmentsMetadata. The result of API.getSegmentsMetadata gets filtered out for API.get and system test cases starts to fail.

To solve the issue, before calling the API, we check if its the allowed metadata API and will filter only if its true.
This solves the metadata response getting filtered for other APIs like API.get

Review

Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AltamashShaikh if that solves the problem you were having, that should be good to merge.

@tsteur tsteur merged commit 9fa38fe into 4.x-dev Dec 16, 2021
@tsteur tsteur deleted the filter-metadata-response-conditionally branch December 16, 2021 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants