Description:

In the FieldAngularJsTemplate.vue component we clone the form field value before it goes to angularjs and vice versa in order to make sure mutations in angularjs, where the data is meant to be mutable, doesn't create unexpected changes in the Vue layer, where the data is not meant to be modified by the form field components. Currently this causes an infinite loop in some cases as we check instance equality, and the instance changes when we clone the value. Fixed by doing a deep equal before propagating changes from either side.

Review

• Functional review done
• Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• Security review done
• Wording review done
• Code review done
• Tests were added if useful/possible
• Reviewed for breaking changes
• Developer changelog updated if needed
• Documentation added if needed
• Existing documentation updated if needed