Ensure updates are always done with super user permission #18503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
Bug
tsteur
requested changes
Dec 14, 2021
There was a problem hiding this comment.
@sgiehl is it possible to only execute the needed methods as superuser? Eg
- $this->doExecuteUpdates($viewDone, $updater, $componentsWithUpdateFile);
- $componentsWithUpdateFile = $updater->getComponentUpdates();
Just to avoid potential security issues etc. Eg some fatal error and then suddenly it keeps super user or maybe some view would expose information a regular user shouldn't see or so?
|
@tsteur moved setting the super user permission to the parts in Updater class, where it's needed. Guess that makes more sense, than doing it in a controller |
tsteur
reviewed
Dec 15, 2021
tsteur
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Our process for performing updates is currently designed in a way that allows anyone (even without permission) to trigger the database updates (once the files were updated).
This can currently lead to errors or differing results depending on the current users permissions.
I saw this basically for this update script where I saw differing results:
matomo/core/Updates/4.6.0-b4.php
Lines 54 to 58 in 4fe950a
Initializing a segment using
new Segmenttries to perform an API request toAPI.getSegmentsMetadatain the background. Based on the current user this might return either the segments (user with view permission) or an error (user without permission). This causes the resulting list of generated queries to be different depending on the user.In that case this might not be that problematic, but there could be cases where it could even break something.
Therefor it's imho required to perform the migration scripts as superuser always.
Review