[VUE] add report date #18498
Merged
[VUE] add report date #18498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add report data back
justinvelluppillai
added
the
not-in-changelog
|
@peterhashair why does this pass without needing an update to a UI test screenshot? edit: I see, because it's a date it is purposely hidden and not tested in UI tests. |
added 2 commits
December 14, 2021 15:56
update test contain report date
update screenshots
|
@justinvelluppillai update the testing logic a little bit, should show the screenshot test with report date. |
diosmosis
reviewed
Dec 14, 2021
| @@ -56,6 +56,8 @@ | |||
| v-show="showInlineHelp" | |||
| > | |||
| <div v-html="$sanitize(actualInlineHelp)"/> | |||
| <span class="helpDate" | |||
| v-html="reportGenerated"></span> | |||
There was a problem hiding this comment.
Should this be $sanitize(reportGenerated)? v-html doesn't perform any sanitization.
There was a problem hiding this comment.
The reportGenerated should contain text only, which is coming from a translation. Guess it would not hurt to add it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add report data back
Description:
Add report date back, I think is missing a test, If I am right, there is one here, but somehow it does contain the report generated date, I will make a UI test I guess. https://github.com/matomo-org/matomo/blob/4.x-dev/tests/UI/expected-screenshots/UIIntegrationTest_actions_pages_tooltip_help.png
Review