Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comparisons are partially broken #18496

Closed
sgiehl opened this issue Dec 13, 2021 · 0 comments · Fixed by #18497
Closed

Comparisons are partially broken #18496

sgiehl opened this issue Dec 13, 2021 · 0 comments · Fixed by #18497
Assignees
@diosmosis
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
4.7.0

Comments

@sgiehl
Copy link
Member

sgiehl commented Dec 13, 2021

It seems due to the vue migration the comparison feature is currently broken on 4.x-dev.
This doen't work correctly anymore:

  • When a segment was chosen for comparison, opening the period selector also shows the compare dates as selected, even though it wasn't
  • Choosing a date for comparison always removes all previously compared segments.
@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Dec 13, 2021
@sgiehl sgiehl added this to the 4.7.0 milestone Dec 13, 2021
@diosmosis diosmosis mentioned this issue Dec 13, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diosmosis diosmosis

Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.7.0
Development

Successfully merging a pull request may close this issue.

fix two regressions in period selector comparison launching/detection matomo-org/matomo
2 participants
@diosmosis @sgiehl