convert sparkline api to one request - fixes archive #18493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update lock
update sparkline
update title link
add comments
update loader
update template
update to visualise
update controller
revert lock
update matrix
update config title
remove template
remove mutilple
us getMetrics
update tests
Co-authored-by: Ben Burgess <88810029+bx80@users.noreply.github.com>
Co-authored-by: Ben Burgess <88810029+bx80@users.noreply.github.com>
# Conflicts: # plugins/CoreHome/vue/dist/CoreHome.umd.min.js
update umd js
update goal remove revenue sparkline
remove hide extra columns
update graphic
peterhashair
added
Needs Review
|
this is the follow-up on the UI failed fixes. Should pass the test now. |
|
@peterhashair The only remaining failing UI screenshot |
added 2 commits
December 15, 2021 15:31
update remove goal in the settings
update screenshot
bx80
approved these changes
Dec 16, 2021
There was a problem hiding this comment.
UI tests are now all passing.
I noticed that because the GetMetrics report is a now a descendant of the Get report that the view is configured slightly differently with overview Goal Names shown as Goal 'Something' instead of Goal Something. This would seem to be more consistent, what do you think @sgiehl ?
sgiehl
requested changes
Dec 16, 2021
Co-authored-by: Stefan Giehl <stefan@matomo.org>
Co-authored-by: Stefan Giehl <stefan@matomo.org>
remove check actions and remove foreach loop on goals
sgiehl
requested changes
Dec 17, 2021
Co-authored-by: Stefan Giehl <stefan@matomo.org>
peterhashair
pushed a commit
that referenced
this pull request
Dec 20, 2021
This reverts commit 36f83c1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Description:
Fixes: #18088.
Follow the fix on UI tests
Review