Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible undefined constant exception when using ssl_no_verify #18491

Merged
merged 1 commit into from Dec 14, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Dec 11, 2021

Description:

fixes #18481

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Dec 11, 2021
@sgiehl sgiehl added this to the 4.7.0 milestone Dec 11, 2021
Copy link
Contributor

@justinvelluppillai justinvelluppillai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this change make the second check redundant now? Prior to PHP8.0 I guess @ suppressed the error when the constant wasn't defined, now we have to check more explicitly, I think the @ at least is not needed.

@sgiehl
Copy link
Member Author

sgiehl commented Dec 13, 2021

Only wanted to change as less as possible, as it is actually a third party library. Even though we should try to get rid of it some day.

Copy link
Contributor

@justinvelluppillai justinvelluppillai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@justinvelluppillai justinvelluppillai merged commit e8ae968 into 4.x-dev Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix possible undefined constant exception when using ssl_no_verify
2 participants