Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API language reworked #18488

Merged
merged 2 commits into from Dec 15, 2021
Merged

API language reworked #18488

merged 2 commits into from Dec 15, 2021

Conversation

comradekingu
Copy link
Contributor

@comradekingu comradekingu commented Dec 10, 2021 •
edited

Description:

Language changed to look a bit more friendly, shorter, and professional.

Review

@sgiehl sgiehl added c: i18n For issues around internationalisation and localisation. Needs Review PRs that need a code review labels Dec 13, 2021
justinvelluppillai
justinvelluppillai approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@justinvelluppillai justinvelluppillai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for these improvements

@justinvelluppillai
Copy link
Contributor

I will fix failing tests and merge this

@justinvelluppillai justinvelluppillai changed the base branch from 4.x-dev to j-18488-testfixes December 15, 2021 03:11
@justinvelluppillai justinvelluppillai merged commit 1fe4260 into matomo-org:j-18488-testfixes Dec 15, 2021
@justinvelluppillai justinvelluppillai mentioned this pull request Dec 15, 2021
Merged
11 tasks
justinvelluppillai added a commit that referenced this pull request Dec 15, 2021
@justinvelluppillai @comradekingu
API Language updates (#18506)
2ef991a 
* Updated screenshots and expected XML for failing tests

* API language reworked (#18488)

* API language reworked

* Suggested change made

* Another fixed expected test xml

Co-authored-by: Allan Nordhøy <epost@anotheragency.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinvelluppillai justinvelluppillai justinvelluppillai approved these changes

Assignees
No one assigned
Labels
c: i18n For issues around internationalisation and localisation. Needs Review PRs that need a code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@comradekingu @justinvelluppillai @sgiehl