@comradekingu opened this Pull Request on December 10th 2021 Contributor

Description:

Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.

Review

@justinvelluppillai commented on December 13th 2021 Member

Thanks @comradekingu for this PR. As there are some high impact changes here we will just discuss internally before merging this one.

@github-actions[bot] commented on December 22nd 2021 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@justinvelluppillai commented on January 19th 2022 Member

Closing for now as this has gone stale but happy to merge with the suggested changes from review if you wish to reopen @comradekingu.

@comradekingu commented on January 19th 2022 Contributor

@justinvelluppillai If you reopen it I can fix it.
The suggested changes amount to one good change, and one omission.

@justinvelluppillai commented on January 19th 2022 Member

Be all good to merge if you can action the changes mentioned. Nothing major there I agree, but good to keep them for consistency and other various reasons overall.

@comradekingu commented on January 19th 2022 Contributor

@justinvelluppillai Why the concern for supposed consistency matters down to the most minute detail here, and now, I really don't know. From what I can tell it is spectacularly bad all around. That matters.

Other PRs it was just fine to do this, but here it has to be some other way.
If not for having this needless consideration in place, I could have some impact on the entire string-base by now. In turn it could be easy to translate Matomo, whereas now it is a struggle.

@comradekingu commented on January 19th 2022 Contributor

@justinvelluppillai Back up with no breaking changes, and "make sure some extra code is added to each of your webpages" from https://hosted.weblate.org/translate/matomo/plugin-installation/en/?checksum=4b65498c162f5541 reinstated.

This Pull Request was closed on January 21st 2022
Powered by GitHub Issue Mirror