@AltamashShaikh opened this Pull Request on December 10th 2021 Contributor

Description:

Added code to filter metadata response before XML comparison.

The previous code changes added to filter metadata response was breaking other API tests like API.get which internally tries to call API.getSegmentsMetadata. The result of API.getSegmentsMetadata gets filtered out for API.get and system testcases starts to fail.

To solve the issue, will be filtering the XML response just before we compare the processed and expected output.

Review

@AltamashShaikh commented on December 15th 2021 Contributor

@tsteur I have 1 better way which can work by tweaking the existing logic
I can show it to you tomorrow and we can decide which 1 should we choose

@tsteur commented on December 15th 2021 Member

OK. Generally 1 way is enough though since it's quite small logic and not too complex it be probably fine as it is and don't need to optimise further. Unless there's some other benefit?

@AltamashShaikh commented on December 16th 2021 Contributor

Created #18510
As it is a much simpler approach closing this.

This Pull Request was closed on December 16th 2021
Powered by GitHub Issue Mirror