Added code to filter metadata response before xml comparison #18482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tsteur I have 1 better way which can work by tweaking the existing logic |
|
OK. Generally 1 way is enough though since it's quite small logic and not too complex it be probably fine as it is and don't need to optimise further. Unless there's some other benefit? |
|
Created #18510 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added code to filter metadata response before XML comparison.
The previous code changes added to filter metadata response was breaking other API tests like
API.getwhich internally tries to callAPI.getSegmentsMetadata. The result ofAPI.getSegmentsMetadatagets filtered out forAPI.getand system testcases starts to fail.To solve the issue, will be filtering the XML response just before we compare the processed and expected output.
Review