Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue] add report generated styling and element to vue component #18478

Closed
wants to merge 3 commits into from

Conversation

diosmosis
Copy link
Member

Description:

Fixes #18476

Not sure how, but the report generated styling and element was not added to the Vue component. Adding it back.

Review

@diosmosis diosmosis added the Needs Review PRs that need a code review label Dec 9, 2021
@diosmosis diosmosis added this to the 4.6.2 milestone Dec 9, 2021
@diosmosis diosmosis changed the base branch from 4.x-dev to next_release December 9, 2021 22:33
@sgiehl
Copy link
Member

sgiehl commented Dec 9, 2021

@diosmosis the submodule changes should be reverted I guess

@diosmosis
Copy link
Member Author

@sgiehl done

Copy link
Contributor

@peterhashair peterhashair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to go, but the actually report-generated I thought is removed before. I mean this part here.
https://github.com/matomo-org/matomo/pull/18035/files

    <div v-show="showReportGenerated" class="icon-clock report-generated"></div>

@justinvelluppillai
Copy link
Contributor

@peterhashair is right, this was removed in #18035 on purpose, and is displayed differently now. I have closed the issue and will close this PR also.

@sgiehl sgiehl deleted the vue-report-generated-missing branch April 5, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report generated info missing since Matomo 4.6.x
4 participants