@diosmosis opened this Pull Request on December 9th 2021 Member

Description:

Changes:

  • update screenshot failure due to submodule that hasn't been updated
  • better race condition fix for creating dashboard (rebuild menu and reload dashboards before loading new page, or page load will abort ongoing requests)
  • race condition fix for removing dashboard (wait for menu rebuild before loading new page or page load will abort ongoing requests)

Review

@sgiehl commented on December 9th 2021 Member

@diosmosis the regression when removing a dashboard seems to be fixed. But I found something else while testing it.
If you add a new dashboard, and the amount of dashboard is or gets bigger than 5, the dropdown menu is displayed. When the new dashboard is created, it is loaded correctly, but the value in the drop down isn't updated to it. Opening the drow down shows it as selected though.

@sgiehl commented on December 9th 2021 Member

And another thing that might be nice to fix at some point. When switching the dashboard the hash is updated to always include &segment=&comparePeriods=&compareDates=&compareSegments=. Would it be easily possible to remove empty parameters from the hash?

@sgiehl commented on December 9th 2021 Member

And another one 🙈
When I initially choose a goal in the dropdown menu, the value is always updated to the first goals name, even though another has been clicked and is loaded. (It works correctly when switching to another goal afterwards.)

@sgiehl commented on December 9th 2021 Member

Seems the reported issues are now fixed. But I actually found something else. It seems the drop downs in the menu are somehow connected. E.g. when I load the second dashboard and open the goals submenu, the second goal is preselected. Changing the dashboard also preselects another goal....

@diosmosis commented on December 9th 2021 Member

@sgiehl pushed another fix

@diosmosis commented on December 9th 2021 Member

@sgiehl pushed another update

This Pull Request was closed on December 10th 2021
Powered by GitHub Issue Mirror