Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue] fix build + race condition fixes #18474

Merged
merged 8 commits into from Dec 10, 2021
Merged

[Vue] fix build + race condition fixes #18474

merged 8 commits into from Dec 10, 2021

Conversation

diosmosis
Copy link
Member

Description:

Changes:

  • update screenshot failure due to submodule that hasn't been updated
  • better race condition fix for creating dashboard (rebuild menu and reload dashboards before loading new page, or page load will abort ongoing requests)
  • race condition fix for removing dashboard (wait for menu rebuild before loading new page or page load will abort ongoing requests)

Review

@diosmosis diosmosis added this to the 4.7.0 milestone Dec 9, 2021
@diosmosis diosmosis requested a review from sgiehl December 9, 2021 09:46
@sgiehl
Copy link
Member

sgiehl commented Dec 9, 2021

@diosmosis the regression when removing a dashboard seems to be fixed. But I found something else while testing it.
If you add a new dashboard, and the amount of dashboard is or gets bigger than 5, the dropdown menu is displayed. When the new dashboard is created, it is loaded correctly, but the value in the drop down isn't updated to it. Opening the drow down shows it as selected though.

@sgiehl
Copy link
Member

sgiehl commented Dec 9, 2021

And another thing that might be nice to fix at some point. When switching the dashboard the hash is updated to always include &segment=&comparePeriods=&compareDates=&compareSegments=. Would it be easily possible to remove empty parameters from the hash?

@sgiehl
Copy link
Member

sgiehl commented Dec 9, 2021

And another one 🙈
When I initially choose a goal in the dropdown menu, the value is always updated to the first goals name, even though another has been clicked and is loaded. (It works correctly when switching to another goal afterwards.)

@sgiehl
Copy link
Member

sgiehl commented Dec 9, 2021

Seems the reported issues are now fixed. But I actually found something else. It seems the drop downs in the menu are somehow connected. E.g. when I load the second dashboard and open the goals submenu, the second goal is preselected. Changing the dashboard also preselects another goal....

…subcategory is based on displayed category, not on manually set active category
@diosmosis
Copy link
Member Author

@sgiehl pushed another fix

@diosmosis
Copy link
Member Author

@sgiehl pushed another update

Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now everything seems to work as expected 👍

@sgiehl sgiehl merged commit e669bec into 4.x-dev Dec 10, 2021
@sgiehl sgiehl deleted the fix-build branch December 10, 2021 08:37
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants