New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vue] fix build + race condition fixes #18474
Conversation
…race condition fix for remove dashboard
@diosmosis the regression when removing a dashboard seems to be fixed. But I found something else while testing it. |
And another thing that might be nice to fix at some point. When switching the dashboard the hash is updated to always include |
And another one 🙈 |
…wn input when changing the subcategory in a dropdown
Seems the reported issues are now fixed. But I actually found something else. It seems the drop downs in the menu are somehow connected. E.g. when I load the second dashboard and open the goals submenu, the second goal is preselected. Changing the dashboard also preselects another goal.... |
…subcategory is based on displayed category, not on manually set active category
@sgiehl pushed another fix |
@sgiehl pushed another update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now everything seems to work as expected 👍
Description:
Changes:
Review